Add [] and []= operators for unnamed getters and setters #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes dart-lang#127 The IDL defines unnamed getters or setters which should be emitted as special variants of the index operators.
|
cc @rutvik110 who was curious about generator changes. In general, changes go into
The definition for the parsed IDL comes from https://github.com/w3c/webidl2.js. |
|
Since we're using..."weird" operators, would it make sense to add a simple integration test...for just one of the types here.? |
Yup, I tested this locally anyways, so no reason not to add a test for it. I added a smoke test for examples of |
kevmoo
approved these changes
Aug 28, 2024
kevmoo
reviewed
Aug 28, 2024
| @@ -51,4 +51,15 @@ void main() { | |||
| expect(div.style.textOverflow, equals('ellipsis')); | |||
| expect(div.style.getPropertyValue('text-overflow'), equals('ellipsis')); | |||
| }); | |||
|
|
|||
| test('External [] and []= operators work as expected.', () { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
The IDL defines unnamed getters or setters which should be emitted as special variants of the index operators.